Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5064)

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view.cc

Issue 2650033004: Show Page Info from Form-Not-Secure 'Learn more' link (Closed)
Patch Set: mathp comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_icon_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.cc b/chrome/browser/ui/views/location_bar/location_icon_view.cc
index 92e6e2d519736d6972b049c208360dd28bb6a195..6d247572502b5316167c668c51a9ce62ae14369d 100644
--- a/chrome/browser/ui/views/location_bar/location_icon_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_icon_view.cc
@@ -106,21 +106,7 @@ bool LocationIconView::OnActivate(const ui::Event& event) {
WebContents* contents = location_bar_->GetWebContents();
if (!contents)
return false;
-
- // Important to use GetVisibleEntry to match what's showing in the omnibox.
- NavigationEntry* entry = contents->GetController().GetVisibleEntry();
- // The visible entry can be nullptr in the case of window.open("").
- if (!entry)
- return false;
-
- SecurityStateTabHelper* helper =
- SecurityStateTabHelper::FromWebContents(contents);
- DCHECK(helper);
- security_state::SecurityInfo security_info;
- helper->GetSecurityInfo(&security_info);
-
- location_bar_->delegate()->ShowWebsiteSettings(
- contents, entry->GetVirtualURL(), security_info);
+ location_bar_->delegate()->ShowWebsiteSettings(contents);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698