Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm

Issue 2650033004: Show Page Info from Form-Not-Secure 'Learn more' link (Closed)
Patch Set: Remove the 'trigger a call to open the url' references Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm b/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
index f8379f5718f516e7c7d2b7a50f8f52d2eefc27a7..be1e5a1c6561c860f183a1351d402f35f5b876fa 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
@@ -6,7 +6,6 @@
#include "base/strings/sys_string_conversions.h"
#include "chrome/browser/search/search.h"
-#include "chrome/browser/ssl/security_state_tab_helper.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
@@ -15,7 +14,6 @@
#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
#include "chrome/grit/generated_resources.h"
#include "components/favicon/content/content_favicon_driver.h"
-#include "components/security_state/core/security_state.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
@@ -128,20 +126,8 @@ bool LocationIconDecoration::OnMousePressed(NSRect frame, NSPoint location) {
return true;
WebContents* tab = owner_->GetWebContents();
- const NavigationController& controller = tab->GetController();
- // Important to use GetVisibleEntry to match what's showing in the omnibox.
- NavigationEntry* nav_entry = controller.GetVisibleEntry();
- if (!nav_entry)
- return true;
Browser* browser = chrome::FindBrowserWithWebContents(tab);
-
- SecurityStateTabHelper* helper = SecurityStateTabHelper::FromWebContents(tab);
- DCHECK(helper);
- security_state::SecurityInfo security_info;
- helper->GetSecurityInfo(&security_info);
-
- chrome::ShowWebsiteSettings(browser, tab, nav_entry->GetVirtualURL(),
- security_info);
+ chrome::ShowWebsiteSettings(browser, tab);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698