Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: components/translate/core/browser/translate_manager.cc

Issue 2650003004: Don't offer to translate between Simplified and Traditional Chinese (Closed)
Patch Set: Updates comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_manager.cc
diff --git a/components/translate/core/browser/translate_manager.cc b/components/translate/core/browser/translate_manager.cc
index 33d3c514a5d011646e21b4c5aedfbff7679a21f6..3bf00260615539e0ad63f032423bb3abb71f905e 100644
--- a/components/translate/core/browser/translate_manager.cc
+++ b/components/translate/core/browser/translate_manager.cc
@@ -224,7 +224,10 @@ void TranslateManager::InitiateTranslation(const std::string& page_lang) {
InitTranslateEvent(language_code, target_lang, *translate_prefs);
// Don't translate similar languages (ex: en-US to en).
- if (language_code == target_lang) {
+ // Also do not offer to translate between Simplified and Traditional Chinese.
+ if (language_code == target_lang ||
+ (language_code == "zh-CN" && target_lang == "zh-TW") ||
+ (language_code == "zh-TW" && target_lang == "zh-CN")) {
TranslateBrowserMetrics::ReportInitiationStatus(
TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
return;

Powered by Google App Engine
This is Rietveld 408576698