Don't offer to translate between Simplified and Traditional Chinese

components/translate/core/browser/translate_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_manager.h"
 
+#include <iostream>

[kjellander_chromium, 2017/01/26 05:30:06]

I'm confused how this could pass the _CheckNoIOStreamInHeaders check in
https://chromium.googlesource.com/chromium/src/+/master/PRESUBMIT.py#395 

iostream will give you static initializers, which are not allowed in Chromium. I
filed crbug.com/685512 for that.

 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
@@ skipping 200 matching lines @@
   std::unique_ptr<TranslatePrefs> translate_prefs(
       translate_client_->GetTranslatePrefs());
 
   std::string target_lang = GetTargetLanguage(translate_prefs.get());
   std::string language_code =
       TranslateDownloadManager::GetLanguageCode(page_lang);
 
   InitTranslateEvent(language_code, target_lang, *translate_prefs);
 
   // Don't translate similar languages (ex: en-US to en).
-  if (language_code == target_lang) {
+  // Also do not offer to translate between Simplified and Traditional Chinese.
+  if (language_code == target_lang ||
+      (language_code == "zh-CN" && target_lang == "zh-TW") ||
+      (language_code == "zh-TW" && target_lang == "zh-CN")) {
     TranslateBrowserMetrics::ReportInitiationStatus(
         TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
     return;
   }
-
   // Nothing to do if either the language Chrome is in or the language of the
   // page is not supported by the translation server.
   if (target_lang.empty() ||
       !TranslateDownloadManager::IsSupportedLanguage(language_code)) {
     TranslateBrowserMetrics::ReportInitiationStatus(
         TranslateBrowserMetrics::INITIATION_STATUS_LANGUAGE_IS_NOT_SUPPORTED);
     TranslateBrowserMetrics::ReportUnsupportedLanguageAtInitiation(
         language_code);
     RecordTranslateEvent(metrics::TranslateEventProto::UNSUPPORTED_LANGUAGE);
     return;
@@ skipping 355 matching lines @@
 void TranslateManager::RecordTranslateEvent(int event_type) {
   DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type));
   translate_event_->set_event_type(
       static_cast<metrics::TranslateEventProto::EventType>(event_type));
   translate_event_->set_event_timestamp_sec(
       (base::TimeTicks::Now() - base::TimeTicks()).InSeconds());
   TranslateRanker::GetInstance()->RecordTranslateEvent(*translate_event_);
 }
 
 }  // namespace translate