content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java - Issue 2649923012: Avoid reporting space as NBSP in TextInputState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

Issue 2649923012: Avoid reporting space as NBSP in TextInputState. (Closed)

Patch Set: Code review comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

index 330863f770afba4ebd4f622cea8c596ed73abd87..f7dd561502a72e98746326fb60ee479245c72d27 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

@@ -119,10 +119,6 @@ class ThreadedInputConnection extends BaseInputConnection implements ChromiumBas

final boolean replyToRequest) {

ImeUtils.checkOnUiThread();

- // crbug.com/663880: Non-breaking spaces can cause the IME to get confused. Replace with

- // normal spaces.

- text = text.replace('\u00A0', ' ');

mCachedTextInputState = new TextInputState(text, new Range(selectionStart, selectionEnd),

new Range(compositionStart, compositionEnd), singleLine, replyToRequest);

if (DEBUG_LOGS) Log.w(TAG, "updateState: %s", mCachedTextInputState);