third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h - Issue 2649923012: Avoid reporting space as NBSP in TextInputState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

Issue 2649923012: Avoid reporting space as NBSP in TextInputState. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp ('K') | « third_party/WebKit/Source/core/editing/iterators/TextIteratorFlags.h ('k') | third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp » ('j') | third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

index fc4cb53757fb3ccc18b5bd82606105dca4617645..5f380f0d676cae68cf1899c3f72ddb56ad85f1fa 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

@@ -39,7 +39,7 @@ class CORE_EXPORT TextIteratorTextState {

STACK_ALLOCATED();

public:

- explicit TextIteratorTextState(bool emitsOriginalText);

+ TextIteratorTextState(bool emitsOriginalText, bool emitsSpaceForNbsp);

~TextIteratorTextState() {}

const String& string() const { return m_text; }

@@ -99,6 +99,7 @@ class CORE_EXPORT TextIteratorTextState {

bool m_hasEmitted;

UChar m_lastCharacter;

bool m_emitsOriginalText;

+ bool m_emitsSpaceForNbsp;

yosin_UTC9 2017/01/25 03:41:23 Let's make this to |const bool| and |m_emitOrigina

aelias_OOO_until_Jul13 2017/01/25 04:33:29 Done.

// Stores the length of :first-letter when we are at the remaining text.

// Equals to 0 in all other cases.