Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2649923012: Avoid reporting space as NBSP in TextInputState. (Closed)
Patch Set: Code review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets 884 // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets
885 // needs to be audited. see http://crbug.com/590369 for more details. 885 // needs to be audited. see http://crbug.com/590369 for more details.
886 document().updateStyleAndLayoutIgnorePendingStylesheets(); 886 document().updateStyleAndLayoutIgnorePendingStylesheets();
887 887
888 DocumentLifecycle::DisallowTransitionScope disallowTransition( 888 DocumentLifecycle::DisallowTransitionScope disallowTransition(
889 document().lifecycle()); 889 document().lifecycle());
890 890
891 // Emits an object replacement character for each replaced element so that 891 // Emits an object replacement character for each replaced element so that
892 // it is exposed to IME and thus could be deleted by IME on android. 892 // it is exposed to IME and thus could be deleted by IME on android.
893 info.value = plainText(EphemeralRange::rangeOfContents(*element), 893 info.value = plainText(EphemeralRange::rangeOfContents(*element),
894 TextIteratorEmitsObjectReplacementCharacter); 894 TextIteratorEmitsObjectReplacementCharacter |
895 TextIteratorEmitsSpaceForNbsp);
895 896
896 if (info.value.isEmpty()) 897 if (info.value.isEmpty())
897 return info; 898 return info;
898 899
899 EphemeralRange firstRange = 900 EphemeralRange firstRange =
900 firstEphemeralRangeOf(frame().selection().selection()); 901 firstEphemeralRangeOf(frame().selection().selection());
901 if (firstRange.isNotNull()) { 902 if (firstRange.isNotNull()) {
902 PlainTextRange plainTextRange(PlainTextRange::create(*element, firstRange)); 903 PlainTextRange plainTextRange(PlainTextRange::create(*element, firstRange));
903 if (plainTextRange.isNotNull()) { 904 if (plainTextRange.isNotNull()) {
904 info.selectionStart = plainTextRange.start(); 905 info.selectionStart = plainTextRange.start();
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
1073 frame().chromeClient().resetInputMethod(); 1074 frame().chromeClient().resetInputMethod();
1074 } 1075 }
1075 1076
1076 DEFINE_TRACE(InputMethodController) { 1077 DEFINE_TRACE(InputMethodController) {
1077 visitor->trace(m_frame); 1078 visitor->trace(m_frame);
1078 visitor->trace(m_compositionRange); 1079 visitor->trace(m_compositionRange);
1079 SynchronousMutationObserver::trace(visitor); 1080 SynchronousMutationObserver::trace(visitor);
1080 } 1081 }
1081 1082
1082 } // namespace blink 1083 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698