Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 26499003: Do not send mouse-move when target is destroyed due to synthesized mouse-exit in RootWindow (Closed)

Created:
7 years, 2 months ago by mohsen
Modified:
7 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Do not send mouse-move when target is destroyed due to synthesized mouse-exit in RootWindow When a RootWindow is going to dispatch a mouse-move to a child, if the target is different than the current mouse_moved_handler_, it sends a synthesized mouse-exit to to mouse_moved_handler_. The target might be destroyed because of this mouse-exit. If that's the case, the original mouse-move should not be sent to the destroyed target. BUG=304276 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227835

Patch Set 1 #

Patch Set 2 : Added unit test #

Total comments: 2

Patch Set 3 : Commented on ownership of event filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M ui/aura/root_window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 1 2 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mohsen
Please take a look...
7 years, 2 months ago (2013-10-08 15:29:15 UTC) #1
sky
You need a test case for this.
7 years, 2 months ago (2013-10-08 15:55:48 UTC) #2
mohsen
Unit test added.
7 years, 2 months ago (2013-10-08 23:20:39 UTC) #3
sky
https://codereview.chromium.org/26499003/diff/11001/ui/aura/root_window_unittest.cc File ui/aura/root_window_unittest.cc (right): https://codereview.chromium.org/26499003/diff/11001/ui/aura/root_window_unittest.cc#newcode1080 ui/aura/root_window_unittest.cc:1080: OnMouseExitDeletingEventFilter* w1_filter = Does this leak?
7 years, 2 months ago (2013-10-09 13:12:43 UTC) #4
sky
And thanks for the test!
7 years, 2 months ago (2013-10-09 13:12:52 UTC) #5
mohsen
https://codereview.chromium.org/26499003/diff/11001/ui/aura/root_window_unittest.cc File ui/aura/root_window_unittest.cc (right): https://codereview.chromium.org/26499003/diff/11001/ui/aura/root_window_unittest.cc#newcode1080 ui/aura/root_window_unittest.cc:1080: OnMouseExitDeletingEventFilter* w1_filter = On 2013/10/09 13:12:44, sky wrote: > ...
7 years, 2 months ago (2013-10-09 15:12:30 UTC) #6
sky
LGTM
7 years, 2 months ago (2013-10-09 16:28:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/26499003/24001
7 years, 2 months ago (2013-10-09 17:06:04 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 23:47:51 UTC) #9
Message was sent while issue was closed.
Change committed as 227835

Powered by Google App Engine
This is Rietveld 408576698