Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2649823002: [ScreenOrientation] Merge ScreenOrientation into ScreenOrientationProvider. (Closed)
Patch Set: Address comments from mlamouri@ Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 1544592b13a2ebac5b6de6ef7e8cdf0db5e479ff..e54f53fb292c0feca7d5e2b8cdbebe0f37becabc 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -73,7 +73,6 @@
#include "content/browser/renderer_host/render_widget_host_input_event_router.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "content/browser/renderer_host/text_input_manager.h"
-#include "content/browser/screen_orientation/screen_orientation.h"
#include "content/browser/site_instance_impl.h"
#include "content/browser/web_contents/web_contents_view_child_frame.h"
#include "content/browser/web_contents/web_contents_view_guest.h"
@@ -929,6 +928,11 @@ WebContentsView* WebContentsImpl::GetView() const {
return view_.get();
}
+ScreenOrientationProvider* WebContentsImpl::GetScreenOrientationProvider()
+ const {
+ return screen_orientation_provider_.get();
+}
+
SkColor WebContentsImpl::GetThemeColor() const {
return theme_color_;
}
@@ -1589,7 +1593,7 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {
NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED,
NotificationService::AllBrowserContextsAndSources());
- screen_orientation_.reset(new ScreenOrientation(this));
+ screen_orientation_provider_.reset(new ScreenOrientationProvider(this));
manifest_manager_host_.reset(new ManifestManagerHost(this));
@@ -2438,10 +2442,6 @@ device::WakeLockServiceContext* WebContentsImpl::GetWakeLockServiceContext() {
return wake_lock_service_context_.get();
}
-ScreenOrientationProvider* WebContentsImpl::GetScreenOrientationProvider() {
- return screen_orientation_.get()->GetScreenOrientationProvider();
-}
-
void WebContentsImpl::OnShowValidationMessage(
RenderViewHostImpl* source,
const gfx::Rect& anchor_in_root_view,

Powered by Google App Engine
This is Rietveld 408576698