Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 26498003: Move ScrollbarThemeClient to Source/platform (Closed)

Created:
7 years, 2 months ago by atreat
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, tommyw+watchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Move ScrollbarThemeClient to Source/platform BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159177

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -103 lines) Patch
M Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/Scrollbar.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/ScrollbarThemeClient.h View 1 chunk +0 lines, -95 lines 0 comments Download
M Source/core/platform/ScrollbarThemeMacNonOverlayAPI.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarThemeMacOverlayAPI.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/support/WebScrollbarThemeClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/mock/ScrollbarThemeMock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbarTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A + Source/platform/scroll/ScrollbarThemeClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
atreat
Moving ScrollbarThemeClient to Source/platform
7 years, 2 months ago (2013-10-08 15:34:24 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-08 16:19:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26498003/1
7 years, 2 months ago (2013-10-08 16:19:44 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/platform/ScrollbarTheme.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-08 16:19:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/26498003/7001
7 years, 2 months ago (2013-10-08 21:10:42 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 00:08:37 UTC) #6
Message was sent while issue was closed.
Change committed as 159177

Powered by Google App Engine
This is Rietveld 408576698