Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 264973016: Add back display names for non-UI languages in A-L list (Closed)

Created:
6 years, 7 months ago by jungshik at Google
Modified:
6 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Add back display names for non-UI languages in A-L list I was too aggressive in trimming the data and dropped the display names for languages that Chromium needs (for non-UI languages that are in the A-L list). It's not my intention (the comment in trim_data.sh said one thing, but the code did another). Besides, add Norweigian (nb) and Malay (ms) locale data that were not included by mistake. Also update trim_data.sh script NOT to drop 'ALIAS' lines which are used to indicate that a given locale is an alias to another locale. That also required adding ro_MD.txt (null locale which mo.txt is aliased to). The above three adds about 110kB to the icu data (from 10.3MB to 10.4MB). Also update the pre-built icu data files for Linux, Mac and Windows. The Android data will be updated in a follow-up patch. BUG=132145 TEST=When ICU is rolled, unit_tests:ExtensionL10* pass. TBR=mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5947 lines, -16 lines) Patch
M scripts/accept_lang.list View 3 chunks +5 lines, -1 line 0 comments Download
M scripts/chrome_ui_languages.list View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/trim_data.sh View 5 chunks +19 lines, -10 lines 0 comments Download
M source/data/in/icudtl.dat View Binary file 0 comments Download
M source/data/lang/am.txt View 1 chunk +88 lines, -0 lines 0 comments Download
M source/data/lang/ar.txt View 1 chunk +90 lines, -0 lines 0 comments Download
M source/data/lang/bg.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/bn.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/ca.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/cs.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/da.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/de.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/el.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/en.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/es.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/et.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/fa.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/fi.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/fil.txt View 1 chunk +87 lines, -0 lines 0 comments Download
M source/data/lang/fr.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/gu.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/he.txt View 1 chunk +90 lines, -0 lines 0 comments Download
M source/data/lang/hi.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/hr.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/hu.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/id.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/it.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/ja.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/kn.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/ko.txt View 1 chunk +90 lines, -0 lines 0 comments Download
M source/data/lang/lt.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/lv.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/ml.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/mr.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/ms.txt View 1 chunk +88 lines, -0 lines 0 comments Download
M source/data/lang/nb.txt View 1 chunk +336 lines, -0 lines 0 comments Download
M source/data/lang/nl.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/no.txt View 1 chunk +0 lines, -1 line 0 comments Download
M source/data/lang/pl.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/pt.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/pt_PT.txt View 1 chunk +65 lines, -0 lines 0 comments Download
M source/data/lang/ro.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/ru.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/sh.txt View 1 chunk +0 lines, -1 line 0 comments Download
M source/data/lang/sk.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/sl.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/sr.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/sv.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/sw.txt View 1 chunk +86 lines, -0 lines 0 comments Download
M source/data/lang/ta.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/te.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/th.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/tr.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/uk.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/vi.txt View 1 chunk +90 lines, -0 lines 0 comments Download
M source/data/lang/zh.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/lang/zh_Hant.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M source/data/locales/mo.txt View 1 chunk +1 line, -0 lines 0 comments Download
M source/data/locales/nb.txt View 1 chunk +1077 lines, -0 lines 0 comments Download
M source/data/locales/reslocal.mk View 2 chunks +2 lines, -1 line 0 comments Download
M windows/icudt.dll View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
TBRing.
6 years, 7 months ago (2014-05-05 21:54:10 UTC) #1
jungshik at Google
Committed patchset #1 manually as r268285 (presubmit successful).
6 years, 7 months ago (2014-05-05 21:55:28 UTC) #2
Mark Mentovai
6 years, 7 months ago (2014-05-05 21:57:00 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698