Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 264973013: Don't add code dependencies eagerly for HCheckMaps. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Don't add code dependencies eagerly for HCheckMaps. Instead of adding code dependencies on stable during graph creation, we now add them during code generation for those HCheckMaps that survived dead code elimination. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21139

Patch Set 1 #

Patch Set 2 : Fix typo on arm64. #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -173 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +7 lines, -11 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/hydrogen.cc View 11 chunks +13 lines, -37 lines 0 comments Download
M src/hydrogen-instructions.h View 9 chunks +47 lines, -19 lines 0 comments Download
M src/hydrogen-instructions.cc View 8 chunks +49 lines, -43 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M src/lithium.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/lithium.cc View 2 chunks +10 lines, -1 line 0 comments Download
M src/lithium-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/lithium-codegen.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 7 months ago (2014-05-05 10:39:23 UTC) #1
Sven Panne
lgtm
6 years, 7 months ago (2014-05-05 11:01:05 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-05 11:03:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21139 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698