src/json-stringifier.h - Issue 264973008: Checks for empty array case added before casting elements to FixedDoubleArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-stringifier.h

Issue 264973008: Checks for empty array case added before casting elements to FixedDoubleArray. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/json-stringifier.h

diff --git a/src/json-stringifier.h b/src/json-stringifier.h

index c93196e0c9f18e440296d76d8f4dc5cbb34d1fc7..7eb6746dfbebb802e1c7c18fb18c389e600bf230 100644

--- a/src/json-stringifier.h

+++ b/src/json-stringifier.h

@@ -560,6 +560,8 @@ BasicJsonStringifier::Result BasicJsonStringifier::SerializeJSArray(

break;

}

case FAST_DOUBLE_ELEMENTS: {

+ // Empty array is FixedArray but not FixedDoubleArray.

+ if (length == 0) break;

Handle<FixedDoubleArray> elements(

FixedDoubleArray::cast(object->elements()), isolate_);

for (uint32_t i = 0; i < length; i++) {

« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »