Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 264973008: Checks for empty array case added before casting elements to FixedDoubleArray. (Closed)

Created:
6 years, 7 months ago by Igor Sheludko
Modified:
6 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Checks for empty array case added before casting elements to FixedDoubleArray. BUG=chromium:369450 LOG=N R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/json-stringifier.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-369450.js View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 7 months ago (2014-05-02 11:28:34 UTC) #1
Benedikt Meurer
lgtm
6 years, 7 months ago (2014-05-02 11:29:07 UTC) #2
Igor Sheludko
6 years, 7 months ago (2014-05-02 11:30:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698