Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 264973003: Remove layout tests for the legacy x-webkit-speech API (Closed)

Created:
6 years, 7 months ago by hans
Modified:
6 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove layout tests for the legacy x-webkit-speech API The API has been considered deprecated for some time, was disabled in https://src.chromium.org/viewvc/blink?revision=171373&view=revision, and the Chromium implementation is being deleted. Removing the tests allows us to remove Chromium's MockWebSpeechInputController, which is the last consumer of the public WebSpeechInput* classes. BUG=223198 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5917 lines) Patch
M LayoutTests/fast/forms/input-type-change-focusout.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-type-change-focusout-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-user-modify.html View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/input-user-modify-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/textfield-clone.html View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/textfield-clone-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/speech/bubble-position.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/fast/speech/bubble-position-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/speech/bubble-position-scrolled.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/fast/speech/bubble-position-scrolled-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/speech/change-focus.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/fast/speech/change-focus-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/speech/input-appearance-numberandspeech.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/speech/input-appearance-searchandspeech.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/speech/input-appearance-speechbutton.html View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/fast/speech/input-onspeechchange-event.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/speech/input-onspeechchange-event-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/speech/input-ontextinput-event.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/fast/speech/input-ontextinput-event-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/speech/input-readonly-and-disabled.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/speech/input-readonly-and-disabled-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/speech/input-text-language-tag.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/fast/speech/input-text-language-tag-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/speech/input-text-speechbutton.html View 1 chunk +0 lines, -58 lines 0 comments Download
D LayoutTests/fast/speech/input-text-speechbutton-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/speech/input-text-speechstart.html View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/fast/speech/input-text-speechstart-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/speech/intrinsic-input-width-with-speech-border-padding.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/speech/intrinsic-input-width-with-speech-border-padding-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/speech/speech-bidi-rendering.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/fast/speech/speech-button-ignore-generated-events.html View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/fast/speech/speech-button-ignore-generated-events-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/speech/speech-input-result-list-not-enough-arguments.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/speech/speech-input-result-list-not-enough-arguments-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/speech/speech-input-scripting.html View 1 chunk +0 lines, -74 lines 0 comments Download
D LayoutTests/fast/speech/speech-input-scripting-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/speech/speech-style-on-non-speech-elements.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/speech/speech-style-on-non-speech-elements-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/android/fast/speech/input-appearance-numberandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/speech/input-appearance-numberandspeech-expected.txt View 1 chunk +0 lines, -355 lines 0 comments Download
D LayoutTests/platform/android/fast/speech/input-appearance-searchandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/speech/input-appearance-searchandspeech-expected.txt View 1 chunk +0 lines, -499 lines 0 comments Download
D LayoutTests/platform/android/fast/speech/input-appearance-speechbutton-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/speech/input-appearance-speechbutton-expected.txt View 1 chunk +0 lines, -270 lines 0 comments Download
D LayoutTests/platform/android/fast/speech/speech-bidi-rendering-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/speech/speech-bidi-rendering-expected.txt View 1 chunk +0 lines, -99 lines 0 comments Download
D LayoutTests/platform/linux/fast/speech/input-appearance-numberandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/speech/input-appearance-numberandspeech-expected.txt View 1 chunk +0 lines, -356 lines 0 comments Download
D LayoutTests/platform/linux/fast/speech/input-appearance-searchandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/speech/input-appearance-searchandspeech-expected.txt View 1 chunk +0 lines, -516 lines 0 comments Download
D LayoutTests/platform/linux/fast/speech/input-appearance-speechbutton-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/speech/input-appearance-speechbutton-expected.txt View 1 chunk +0 lines, -285 lines 0 comments Download
D LayoutTests/platform/linux/fast/speech/speech-bidi-rendering-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/speech/input-appearance-numberandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/speech/input-appearance-searchandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/speech/input-appearance-speechbutton-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/speech/speech-bidi-rendering-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/speech/input-appearance-numberandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/speech/input-appearance-numberandspeech-expected.txt View 1 chunk +0 lines, -356 lines 0 comments Download
D LayoutTests/platform/mac/fast/speech/input-appearance-searchandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/speech/input-appearance-searchandspeech-expected.txt View 1 chunk +0 lines, -516 lines 0 comments Download
D LayoutTests/platform/mac/fast/speech/input-appearance-speechbutton-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/speech/input-appearance-speechbutton-expected.txt View 1 chunk +0 lines, -285 lines 0 comments Download
D LayoutTests/platform/mac/fast/speech/speech-bidi-rendering-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/speech/speech-bidi-rendering-expected.txt View 1 chunk +0 lines, -100 lines 0 comments Download
D LayoutTests/platform/win/fast/speech/input-appearance-numberandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/speech/input-appearance-numberandspeech-expected.txt View 1 chunk +0 lines, -356 lines 0 comments Download
D LayoutTests/platform/win/fast/speech/input-appearance-searchandspeech-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/speech/input-appearance-searchandspeech-expected.txt View 1 chunk +0 lines, -516 lines 0 comments Download
D LayoutTests/platform/win/fast/speech/input-appearance-speechbutton-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/speech/input-appearance-speechbutton-expected.txt View 1 chunk +0 lines, -285 lines 0 comments Download
D LayoutTests/platform/win/fast/speech/speech-bidi-rendering-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/speech/speech-bidi-rendering-expected.txt View 1 chunk +0 lines, -100 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hans
Please take a look. I started removing the Chromium side here: https://codereview.chromium.org/260903010/
6 years, 7 months ago (2014-05-01 21:14:22 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 7 months ago (2014-05-01 21:19:25 UTC) #2
eseidel
lgtm
6 years, 7 months ago (2014-05-01 21:23:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/264973003/1
6 years, 7 months ago (2014-05-01 21:23:47 UTC) #4
eseidel
lgtm Presumably you plan to delete all the code too, once the tests are gone. ...
6 years, 7 months ago (2014-05-01 21:24:12 UTC) #5
hans
On 2014/05/01 21:24:12, eseidel wrote: > Presumably you plan to delete all the code too, ...
6 years, 7 months ago (2014-05-01 21:34:27 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 21:37:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink
6 years, 7 months ago (2014-05-01 21:37:40 UTC) #8
hans
The CQ bit was checked by hans@chromium.org
6 years, 7 months ago (2014-05-01 21:40:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/264973003/1
6 years, 7 months ago (2014-05-01 21:40:23 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 22:53:24 UTC) #11
Message was sent while issue was closed.
Change committed as 173128

Powered by Google App Engine
This is Rietveld 408576698