Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 26497003: Remove NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED from browser plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 0c2542478aaf2d9a4b01495dd6f11824ffd190c7..408290fa2fa95154aa405ada27f2de9b637d1bae 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -33,8 +33,6 @@
#include "content/port/common/input_event_ack_state.h"
#include "content/public/browser/browser_plugin_guest_delegate.h"
#include "content/public/browser/javascript_dialog_manager.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/render_view_host_observer.h"
#include "content/public/browser/web_contents_delegate.h"
#include "content/public/browser/web_contents_observer.h"
@@ -85,7 +83,6 @@ struct MediaStreamRequest;
// which means it can share storage and can script this guest.
class CONTENT_EXPORT BrowserPluginGuest
: public JavaScriptDialogManager,
- public NotificationObserver,
public WebContentsDelegate,
public WebContentsObserver,
public base::SupportsWeakPtr<BrowserPluginGuest> {
@@ -104,10 +101,13 @@ class CONTENT_EXPORT BrowserPluginGuest
BrowserPluginGuest* opener,
bool has_render_view);
- // Called when the embedder RenderViewHost is destroyed to give the
+ // Called when the embedder WebContents is destroyed to give the
// BrowserPluginGuest an opportunity to clean up after itself.
void EmbedderDestroyed();
+ // Called when the embedder WebContents changes visibility.
+ void EmbedderVisibilityChanged(bool visible);
+
// Destroys the guest WebContents and all its associated state, including
// this BrowserPluginGuest, and its new unattached windows.
void Destroy();
@@ -149,11 +149,6 @@ class CONTENT_EXPORT BrowserPluginGuest
void UpdateVisibility();
- // NotificationObserver implementation.
- virtual void Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details) OVERRIDE;
-
// WebContentsObserver implementation.
virtual void DidCommitProvisionalLoadForFrame(
int64 frame_id,
@@ -297,7 +292,7 @@ class CONTENT_EXPORT BrowserPluginGuest
const std::string& user_input);
private:
- class EmbedderRenderViewHostObserver;
+ class EmbedderWebContentsObserver;
friend class TestBrowserPluginGuest;
class DownloadRequest;
@@ -476,8 +471,7 @@ class CONTENT_EXPORT BrowserPluginGuest
// Static factory instance (always NULL for non-test).
static BrowserPluginHostFactory* factory_;
- NotificationRegistrar notification_registrar_;
- scoped_ptr<EmbedderRenderViewHostObserver> embedder_rvh_observer_;
+ scoped_ptr<EmbedderWebContentsObserver> embedder_web_contents_observer_;
WebContentsImpl* embedder_web_contents_;
std::map<int, int> bridge_id_to_request_id_map_;
« no previous file with comments | « no previous file | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698