Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 26497003: Remove NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED from browser plugin. (Closed)

Created:
7 years, 2 months ago by Avi (use Gerrit)
Modified:
7 years, 2 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED from browser plugin. BUG=170921 TEST=everything still works Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -74 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 6 chunks +6 lines, -12 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 4 chunks +21 lines, -34 lines 0 comments Download
M content/browser/browser_plugin/test_browser_plugin_guest.h View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/browser_plugin/test_browser_plugin_guest.cc View 4 chunks +6 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
7 years, 2 months ago (2013-10-08 19:16:00 UTC) #1
Fady Samuel
lgtm
7 years, 2 months ago (2013-10-10 15:04:44 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-10 15:13:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/26497003/1
7 years, 2 months ago (2013-10-10 18:27:53 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 21:17:53 UTC) #5
Message was sent while issue was closed.
Change committed as 228003

Powered by Google App Engine
This is Rietveld 408576698