Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6178)

Unified Diff: chrome/browser/payments/chrome_payment_request_delegate.h

Issue 2649683002: [Payments] Improve the closing of the PR dialog. (Closed)
Patch Set: addressed comments from sky Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/payments/chrome_payment_request_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/payments/chrome_payment_request_delegate.h
diff --git a/chrome/browser/payments/chrome_payment_request_delegate.h b/chrome/browser/payments/chrome_payment_request_delegate.h
index 4f54fb5f47d6fc067ede1df71e7f36927908744f..25fb7404c3e3caebfe250f1e410d8188f60844d1 100644
--- a/chrome/browser/payments/chrome_payment_request_delegate.h
+++ b/chrome/browser/payments/chrome_payment_request_delegate.h
@@ -15,15 +15,23 @@ class WebContents;
namespace payments {
class PaymentRequest;
+class PaymentRequestDialog;
class ChromePaymentRequestDelegate : public PaymentRequestDelegate {
public:
explicit ChromePaymentRequestDelegate(content::WebContents* web_contents);
~ChromePaymentRequestDelegate() override {}
- void ShowPaymentRequestDialog(PaymentRequest* request) override;
+ void ShowDialog(PaymentRequest* request) override;
+ void CloseDialog() override;
autofill::PersonalDataManager* GetPersonalDataManager() override;
+ protected:
+ // Reference to the dialog so that we can satisfy calls to CloseDialog(). This
+ // reference is invalid once CloseDialog() has been called on it, because the
+ // dialog will be destroyed. Protected for testing.
+ PaymentRequestDialog* dialog_;
+
private:
// Not owned but outlives the PaymentRequest object that owns this.
content::WebContents* web_contents_;
« no previous file with comments | « no previous file | chrome/browser/payments/chrome_payment_request_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698