WebUI: Undo some usages of ES6 features that break uglify.

chrome/browser/resources/settings/route.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /**
    * Class for navigable routes. May only be instantiated within this file.
    * @constructor
    * @param {string} path
    * @private
@@ skipping 193 matching lines @@
   r.SYSTEM = r.ADVANCED.createSection('/system', 'system');
   r.RESET = r.ADVANCED.createSection('/reset', 'reset');
 
 // <if expr="chromeos">
   // "About" is the only section in About, but we still need to create the route
   // in order to show the subpage on Chrome OS.
   r.ABOUT_ABOUT = r.ABOUT.createSection('/help/about', 'about');
   r.DETAILED_BUILD_INFO = r.ABOUT_ABOUT.createChild('/help/details');
 // </if>
 
   var routeObservers_ = new Set();

[Dan Beam, 2017/01/21 00:47:50]

need to make this an array or something

[dpapad, 2017/01/21 00:55:49]

Done, with Array.from(). Let's see if the compiler knows about it.

[dpapad, 2017/01/21 01:02:47]

Changed to Set#forEach, to avoid the unnecessary conversion to Array.

 
   /** @polymerBehavior */
   var RouteObserverBehavior = {
     /** @override */
     attached: function() {
       assert(!routeObservers_.has(this));
       routeObservers_.add(this);
 
       // Emulating Polymer data bindings, the observer is called when the
       // element starts observing the route.
@@ skipping 80 matching lines @@
    * Helper function to set the current route and notify all observers.
    * @param {!settings.Route} route
    * @param {!URLSearchParams} queryParameters
    * @param {boolean} isPopstate
    */
   var setCurrentRoute = function(route, queryParameters, isPopstate) {
     var oldRoute = currentRoute_;
     currentRoute_ = route;
     currentQueryParameters_ = queryParameters;
     lastRouteChangeWasPopstate_ = isPopstate;
-    for (var observer of routeObservers_)
-      observer.currentRouteChanged(currentRoute_, oldRoute);
+    for (var i = 0; i < routeObservers_.length; i++)
+      routeObservers_[i].currentRouteChanged(currentRoute_, oldRoute);
   };
 
   /** @return {!settings.Route} */
   var getCurrentRoute = function() { return currentRoute_; };
 
   /** @return {!URLSearchParams} */
   var getQueryParameters = function() {
     return new URLSearchParams(currentQueryParameters_);  // Defensive copy.
   };
 
@@ skipping 57 matching lines @@
     RouteObserverBehavior: RouteObserverBehavior,
     getRouteForPath: getRouteForPath,
     initializeRouteFromUrl: initializeRouteFromUrl,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
     lastRouteChangeWasPopstate: lastRouteChangeWasPopstate,
     navigateTo: navigateTo,
     navigateToPreviousRoute: navigateToPreviousRoute,
   };
 });