Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2649663002: WebUI: Undo some usages of ES6 features that break uglify. (Closed)
Patch Set: Fix i->j Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/extension_controlled_indicator.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * 'settings-appearance-page' is the settings page containing appearance 6 * 'settings-appearance-page' is the settings page containing appearance
7 * settings. 7 * settings.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 * @private 223 * @private
224 */ 224 */
225 themeChanged_: function(themeId, useSystemTheme) { 225 themeChanged_: function(themeId, useSystemTheme) {
226 if (themeId) { 226 if (themeId) {
227 assert(!useSystemTheme); 227 assert(!useSystemTheme);
228 228
229 this.browserProxy_.getThemeInfo(themeId).then(function(info) { 229 this.browserProxy_.getThemeInfo(themeId).then(function(info) {
230 this.themeSublabel_ = info.name; 230 this.themeSublabel_ = info.name;
231 }.bind(this)); 231 }.bind(this));
232 232
233 this.themeUrl_ = `https://chrome.google.com/webstore/detail/${themeId}`; 233 this.themeUrl_ = 'https://chrome.google.com/webstore/detail/' + themeId;
234 return; 234 return;
235 } 235 }
236 236
237 var i18nId; 237 var i18nId;
238 // <if expr="is_linux and not chromeos"> 238 // <if expr="is_linux and not chromeos">
239 i18nId = useSystemTheme ? 'systemTheme' : 'classicTheme'; 239 i18nId = useSystemTheme ? 'systemTheme' : 'classicTheme';
240 // </if> 240 // </if>
241 // <if expr="not is_linux or chromeos"> 241 // <if expr="not is_linux or chromeos">
242 i18nId = 'chooseFromWebStore'; 242 i18nId = 'chooseFromWebStore';
243 // </if> 243 // </if>
(...skipping 19 matching lines...) Expand all
263 * @see content::ZoomValuesEqual(). 263 * @see content::ZoomValuesEqual().
264 * @param {number} zoom1 264 * @param {number} zoom1
265 * @param {number} zoom2 265 * @param {number} zoom2
266 * @return {boolean} 266 * @return {boolean}
267 * @private 267 * @private
268 */ 268 */
269 zoomValuesEqual_: function(zoom1, zoom2) { 269 zoomValuesEqual_: function(zoom1, zoom2) {
270 return Math.abs(zoom1 - zoom2) <= 0.001; 270 return Math.abs(zoom1 - zoom2) <= 0.001;
271 }, 271 },
272 }); 272 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/extension_controlled_indicator.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698