components/autofill/core/browser/autofill_experiments.h - Issue 2649623002: [Autofill] Uses uniform margin for icon, label and sublabel in popup

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/browser/autofill_experiments.h

Issue 2649623002: [Autofill] Uses uniform margin for icon, label and sublabel in popup (Closed)

Patch Set: Moves label margin calculation to constructor. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java ('k') | components/autofill/core/browser/autofill_experiments.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_	5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_

6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_	6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/strings/string16.h"	10 #include "base/strings/string16.h"

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
79 unsigned int GetPopupDropdownItemHeight();	79 unsigned int GetPopupDropdownItemHeight();

80	80

81 // Returns true if the icon in the credit card autofill popup must be displayed	81 // Returns true if the icon in the credit card autofill popup must be displayed

82 // before the credit card value or any other suggestion text.	82 // before the credit card value or any other suggestion text.

83 bool IsIconInCreditCardPopupAtStart();	83 bool IsIconInCreditCardPopupAtStart();

84	84

85 // Modifies the suggestion value and label if the new credit card autofill popup	85 // Modifies the suggestion value and label if the new credit card autofill popup

86 // experiment is enabled to tweak the display of the value and label.	86 // experiment is enabled to tweak the display of the value and label.

87 void ModifyAutofillCreditCardSuggestion(struct Suggestion* suggestion);	87 void ModifyAutofillCreditCardSuggestion(struct Suggestion* suggestion);

88	88

	89 // Returns the margin for the icon, label and between icon and label. Returns 0

	90 // if the margin isn't configured in an experiment to tweak autofill popup

	91 // layout.

	92 unsigned int GetPopupMargin();

	93

89 } // namespace autofill	94 } // namespace autofill

90	95

91 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_	96 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXPERIMENTS_H_

OLD	NEW