Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java

Issue 2649623002: [Autofill] Uses uniform margin for icon, label and sublabel in popup (Closed)
Patch Set: Removes the 1px offset because the misalignment between card icon and 'C' in 'Chrom...' appears to … Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.android_webview; 5 package org.chromium.android_webview;
6 6
7 import android.graphics.Color; 7 import android.graphics.Color;
8 import android.view.View; 8 import android.view.View;
9 import android.view.ViewGroup; 9 import android.view.ViewGroup;
10 10
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } 59 }
60 @Override 60 @Override
61 public void suggestionSelected(int listIndex) { 61 public void suggestionSelected(int listIndex) {
62 nativeSuggestionSelected(mNativeAwAutofillClient, listIn dex); 62 nativeSuggestionSelected(mNativeAwAutofillClient, listIn dex);
63 } 63 }
64 @Override 64 @Override
65 public void deleteSuggestion(int listIndex) { } 65 public void deleteSuggestion(int listIndex) { }
66 }); 66 });
67 } 67 }
68 mAutofillPopup.filterAndShow(suggestions, isRtl, Color.TRANSPARENT /* ba ckgroundColor */, 68 mAutofillPopup.filterAndShow(suggestions, isRtl, Color.TRANSPARENT /* ba ckgroundColor */,
69 Color.TRANSPARENT /* dividerColor */, 0 /* dropdownItemHeight */ ); 69 Color.TRANSPARENT /* dividerColor */, 0 /* dropdownItemHeight */ , 0 /* margin */);
70 } 70 }
71 71
72 @CalledByNative 72 @CalledByNative
73 public void hideAutofillPopup() { 73 public void hideAutofillPopup() {
74 if (mAutofillPopup == null) return; 74 if (mAutofillPopup == null) return;
75 mAutofillPopup.dismiss(); 75 mAutofillPopup.dismiss();
76 mAutofillPopup = null; 76 mAutofillPopup = null;
77 } 77 }
78 78
79 @CalledByNative 79 @CalledByNative
(...skipping 13 matching lines...) Expand all
93 String name, String label, int uniqueId) { 93 String name, String label, int uniqueId) {
94 array[index] = new AutofillSuggestion(name, label, DropdownItem.NO_ICON, 94 array[index] = new AutofillSuggestion(name, label, DropdownItem.NO_ICON,
95 false /* isIconAtLeft */, uniqueId, false /* isDeletable */, 95 false /* isIconAtLeft */, uniqueId, false /* isDeletable */,
96 false /* isMultilineLabel */, false /* isBoldLabel */); 96 false /* isMultilineLabel */, false /* isBoldLabel */);
97 } 97 }
98 98
99 private native void nativeDismissed(long nativeAwAutofillClient); 99 private native void nativeDismissed(long nativeAwAutofillClient);
100 private native void nativeSuggestionSelected(long nativeAwAutofillClient, 100 private native void nativeSuggestionSelected(long nativeAwAutofillClient,
101 int position); 101 int position);
102 } 102 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698