Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2649613003: Fix for Animation and other polyfills (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for Animation and other polyfills The polyfill code needs to run before dart_sdk is loaded. Otherwise, the registerExtension step on these types does not work. Also fixes #27605 R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/fd94337b424f672e29c9b3ebeb4d8ab7ef610eb1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -56 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +50 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 chunk +50 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 chunk +50 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_library.js View 1 chunk +0 lines, -48 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +50 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 2 chunks +2 lines, -2 lines 1 comment Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart View 1 chunk +54 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/run.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vsm
https://codereview.chromium.org/2649613003/diff/1/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2649613003/diff/1/pkg/dev_compiler/test/browser/language_tests.js#newcode48 pkg/dev_compiler/test/browser/language_tests.js:48: let num_expected_unittest_fails = 4; This is due to: https://github.com/dart-lang/sdk/issues/26730 ...
3 years, 11 months ago (2017-01-21 00:52:42 UTC) #2
vsm
3 years, 11 months ago (2017-01-24 13:50:04 UTC) #4
vsm
On 2017/01/24 13:50:04, vsm wrote: ping
3 years, 11 months ago (2017-01-25 17:47:46 UTC) #5
Jacob
lgtm
3 years, 11 months ago (2017-01-25 17:50:07 UTC) #6
vsm
3 years, 11 months ago (2017-01-26 00:18:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd94337b424f672e29c9b3ebeb4d8ab7ef610eb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698