Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: mojo/public/cpp/bindings/lib/multiplex_router.h

Issue 2649573004: Mojo bindings: merge the control messages of sending disconnect reason and notifying endpoint close… (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/multiplex_router.h
diff --git a/mojo/public/cpp/bindings/lib/multiplex_router.h b/mojo/public/cpp/bindings/lib/multiplex_router.h
index 0d5899870b829790dbdf356302f09dca4576f87c..f874a4b09fa5f2cff0d1cbf21362f30c7f10b550 100644
--- a/mojo/public/cpp/bindings/lib/multiplex_router.h
+++ b/mojo/public/cpp/bindings/lib/multiplex_router.h
@@ -90,7 +90,10 @@ class MOJO_CPP_BINDINGS_EXPORT MultiplexRouter
ScopedInterfaceEndpointHandle* remote_endpoint) override;
ScopedInterfaceEndpointHandle CreateLocalEndpointHandle(
InterfaceId id) override;
- void CloseEndpointHandle(InterfaceId id, bool is_local) override;
+ void CloseEndpointHandle(
+ InterfaceId id,
+ bool is_local,
+ const base::Optional<DisconnectReason>& reason) override;
InterfaceEndpointController* AttachEndpointClient(
const ScopedInterfaceEndpointHandle& handle,
InterfaceEndpointClient* endpoint_client,
@@ -158,7 +161,9 @@ class MOJO_CPP_BINDINGS_EXPORT MultiplexRouter
bool Accept(Message* message) override;
// PipeControlMessageHandlerDelegate implementation:
- bool OnPeerAssociatedEndpointClosed(InterfaceId id) override;
+ bool OnPeerAssociatedEndpointClosed(
+ InterfaceId id,
+ const base::Optional<DisconnectReason>& reason) override;
bool OnAssociatedEndpointClosedBeforeSent(InterfaceId id) override;
void OnPipeConnectionError();

Powered by Google App Engine
This is Rietveld 408576698