Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: src/debug/debug.js

Issue 2649533002: [wasm] Implement stepping in wasm code (Closed)
Patch Set: Add TODOs Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/debug.js
diff --git a/src/debug/debug.js b/src/debug/debug.js
index 512bedb69fbffd0788ad3ea3180695653f77c6d5..7cb5fda95c5e95437eafea828e5c9608f58450d9 100644
--- a/src/debug/debug.js
+++ b/src/debug/debug.js
@@ -1293,13 +1293,12 @@ DebugCommandProcessor.prototype.processDebugJSONRequest = function(
DebugCommandProcessor.prototype.continueRequest_ = function(request, response) {
// Check for arguments for continue.
if (request.arguments) {
- var action = Debug.StepAction.StepIn;
-
// Pull out arguments.
var stepaction = request.arguments.stepaction;
// Get the stepaction argument.
if (stepaction) {
titzer 2017/01/23 10:10:10 This can probably be further simplified to just be
Clemens Hammacher 2017/01/23 12:25:34 Yang just removed this whole code anyway :)
+ var action;
if (stepaction == 'in') {
action = Debug.StepAction.StepIn;
} else if (stepaction == 'next') {
@@ -1310,10 +1309,10 @@ DebugCommandProcessor.prototype.continueRequest_ = function(request, response) {
throw %make_error(kDebugger,
'Invalid stepaction argument "' + stepaction + '".');
}
- }
- // Set up the VM for stepping.
- this.exec_state_.prepareStep(action);
+ // Set up the VM for stepping.
+ this.exec_state_.prepareStep(action);
+ }
}
// VM should be running after executing this request.

Powered by Google App Engine
This is Rietveld 408576698