chrome/browser/resources/bluetooth_internals/characteristic_list.js - Issue 2649473002: bluetooth: Add control for reading/writing of descriptor values to internals page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/bluetooth_internals/characteristic_list.js

Issue 2649473002: bluetooth: Add control for reading/writing of descriptor values to internals page. (Closed)

Patch Set: Merge upstream, fix formatting Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/bluetooth_internals/descriptor_list.js » ('j') | chrome/browser/resources/bluetooth_internals/descriptor_list.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/bluetooth_internals/characteristic_list.js

diff --git a/chrome/browser/resources/bluetooth_internals/characteristic_list.js b/chrome/browser/resources/bluetooth_internals/characteristic_list.js

index 7fb7708e975a2728bbe57f89e2e6165282b309af..17f4ebab97cd4b01d153c7bad9156b1c631397aa 100644

--- a/chrome/browser/resources/bluetooth_internals/characteristic_list.js

+++ b/chrome/browser/resources/bluetooth_internals/characteristic_list.js

@@ -113,7 +113,13 @@ cr.define('characteristic_list', function() {

/** @private {!value_control.ValueControl} */

this.valueControl_ = new value_control.ValueControl();

- this.valueControl_.load(this.deviceAddress_, this.serviceId_, this.info);

+ this.valueControl_.load({

+ deviceAddress: this.deviceAddress_,

+ serviceId: this.serviceId_,

+ characteristicId: this.info.id,

+ properties: this.info.properties,

+ });

this.valueControl_.setValue(this.info.last_known_value);

/** @private {!descriptor_list.DescriptorList} */