content/browser/browser_plugin/test_guest_manager_delegate.h - Issue 264943006: BrowserPlugin: Simplify content/public API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/test_guest_manager_delegate.h

Issue 264943006: BrowserPlugin: Simplify content/public API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_v1

Patch Set: Fixed nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest_manager.cc ('k') | content/browser/browser_plugin/test_guest_manager_delegate.cc » ('j') | content/public/browser/browser_plugin_guest_manager_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/test_guest_manager_delegate.h

diff --git a/content/browser/browser_plugin/test_guest_manager_delegate.h b/content/browser/browser_plugin/test_guest_manager_delegate.h

index ebd1656957e37222996a129057cb91c062134965..63f281133a2f22e63d3689b9a79cc37c48ab4c20 100644

--- a/content/browser/browser_plugin/test_guest_manager_delegate.h

+++ b/content/browser/browser_plugin/test_guest_manager_delegate.h

@@ -25,14 +25,10 @@ class TestGuestManagerDelegate : public BrowserPluginGuestManagerDelegate {

virtual void AddGuest(int guest_instance_id,

WebContents* guest_web_contents) OVERRIDE;

virtual void RemoveGuest(int guest_instance_id) OVERRIDE;

- virtual WebContents* GetGuestByInstanceID(

+ virtual void MaybeGetGuestByInstanceIDOrKill(

int guest_instance_id,

- int embedder_render_process_id) OVERRIDE;

- virtual bool CanEmbedderAccessInstanceIDMaybeKill(

int embedder_render_process_id,

- int guest_instance_id) OVERRIDE;

- virtual bool CanEmbedderAccessInstanceID(int embedder_render_process_id,

- int guest_instance_id) OVERRIDE;

+ const GuestByInstanceIDCallback& callback) OVERRIDE;

virtual SiteInstance* GetGuestSiteInstance(

const GURL& guest_site) OVERRIDE;

virtual bool ForEachGuest(WebContents* embedder_web_contents,