chrome/browser/guest_view/guest_view_base.cc - Issue 264943006: BrowserPlugin: Simplify content/public API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 264943006: BrowserPlugin: Simplify content/public API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_v1

Patch Set: Fixed nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/guest_view/guest_view_base.cc

diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc

index 80526d55b6ae2ea7ef132b5933ba98b8e57b9da1..a9bcbbf24b12fbcaee9cc61cd09e68d588c30492 100644

--- a/chrome/browser/guest_view/guest_view_base.cc

+++ b/chrome/browser/guest_view/guest_view_base.cc

@@ -87,7 +87,7 @@ GuestViewBase* GuestViewBase::From(int embedder_process_id,

content::WebContents* guest_web_contents =

GuestViewManager::FromBrowserContext(host->GetBrowserContext())->

- GetGuestByInstanceID(guest_instance_id, embedder_process_id);

+ GetGuestByInstanceIDSafely(guest_instance_id, embedder_process_id);

if (!guest_web_contents)

return NULL;

« no previous file with comments | « no previous file | chrome/browser/guest_view/guest_view_manager.h » ('j') | content/public/browser/browser_plugin_guest_manager_delegate.h » ('J')