content/browser/browser_plugin/browser_plugin_embedder.h - Issue 264943006: BrowserPlugin: Simplify content/public API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.h

Issue 264943006: BrowserPlugin: Simplify content/public API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_v1

Patch Set: Addressed Istiaque's comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/guest_view_manager.cc ('K') | « chrome/browser/guest_view/guest_view_manager.cc ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_embedder.h

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h

index bce57a3094070b725604377d074e3584f2124bef..940a75e2ba6e6cdd504b88a4d7151ca38a0c86a6 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.h

+++ b/content/browser/browser_plugin/browser_plugin_embedder.h

@@ -97,6 +97,13 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {

bool UnlockMouseIfNecessaryCallback(const NativeWebKeyboardEvent& event,

BrowserPluginGuest* guest);

+ // Called by the content embedder when a guest is found with the provided

lazyboy 2014/05/06 18:03:54 s/is found/exists

Fady Samuel 2014/05/06 18:13:03 Done.

+ // |instance_id|.

+ void OnGuestCallback(int instance_id,

+ const BrowserPluginHostMsg_Attach_Params& params,

+ const base::DictionaryValue* extra_params,

+ BrowserPluginGuest* guest);

// Message handlers.

void OnAllocateInstanceID(int request_id);