BrowserPlugin: Simplify content/public API

content/browser/browser_plugin/browser_plugin_guest_manager.h

Index: content/browser/browser_plugin/browser_plugin_guest_manager.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest_manager.h b/content/browser/browser_plugin/browser_plugin_guest_manager.h
index 3c157fe3c875258338ea7e08b364a9052e673ed1..0d29d34bd2a2b2cb7c231bd4532df15253689dd6 100644
--- a/content/browser/browser_plugin/browser_plugin_guest_manager.h
+++ b/content/browser/browser_plugin/browser_plugin_guest_manager.h
@@ -71,13 +71,6 @@ class CONTENT_EXPORT BrowserPluginGuestManager :
       const BrowserPluginHostMsg_Attach_Params& params,
       scoped_ptr<base::DictionaryValue> extra_params);
 
-  // Returns a BrowserPluginGuest given an |instance_id|. Returns NULL if the
-  // guest wasn't found.  If the embedder is not permitted to access the given
-  // |instance_id|, the embedder is killed, and NULL is returned.
-  BrowserPluginGuest* GetGuestByInstanceID(
-      int instance_id,
-      int embedder_render_process_id) const;
-
   // Adds a new |guest_web_contents| to the embedder (overridable in test).
   virtual void AddGuest(int instance_id, WebContents* guest_web_contents);
 
@@ -85,10 +78,11 @@ class CONTENT_EXPORT BrowserPluginGuestManager :
   // BrowserPluginGuestManager.
   void RemoveGuest(int instance_id);
 
-  // Returns whether the specified embedder is permitted to access the given
-  // |instance_id|, and kills the embedder if not.
-  bool CanEmbedderAccessInstanceIDMaybeKill(int embedder_render_process_id,
-                                            int instance_id) const;
+  typedef base::Callback<void(BrowserPluginGuest*)> GuestByInstanceIDCallback;

[lazyboy, 2014/05/01 23:27:58]

optional: GuestByInstanceIDCallback can be improved to OnGuestRetrievedCallback
or something similar, so it's more readable.

[Fady Samuel, 2014/05/06 16:51:36]

This whole file is going away in a couple of CLs anyway, so I'm skipping this
optional suggestion.

[lazyboy, 2014/05/06 18:03:54]

SG.

+  void MaybeGetGuestByInstanceIDOrKill(
+       int instance_id,
+       int embedder_render_process_id,
+       const GuestByInstanceIDCallback& callback) const;
 
   typedef base::Callback<bool(BrowserPluginGuest*)> GuestCallback;
   bool ForEachGuest(WebContents* embedder_web_contents,