BrowserPlugin: Simplify content/public API

chrome/browser/guest_view/guest_view_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_
 #define CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_
 
 #include <map>
 
 #include "base/lazy_instance.h"
@@ skipping 11 matching lines @@
 }  // namespace content
 
 class GuestViewManager : public content::BrowserPluginGuestManagerDelegate,
                          public base::SupportsUserData::Data {
  public:
   explicit GuestViewManager(content::BrowserContext* context);
   virtual ~GuestViewManager();
 
   static GuestViewManager* FromBrowserContext(content::BrowserContext* context);
 
+  content::WebContents* GetGuestByInstanceIDSafely(
+      int guest_instance_id,
+      int embedder_render_process_id);
+  bool CanEmbedderAccessInstanceIDMaybeKill(
+      int embedder_render_process_id,
+      int guest_instance_id);
+  bool CanEmbedderAccessInstanceID(int embedder_render_process_id,

[lazyboy, 2014/05/01 23:27:58]

Exposing this publicly defeats the purpose since it can be misused? Don' think
we need to make it public.

[Fady Samuel, 2014/05/06 16:51:36]

Done.

+                                   int guest_instance_id);
+
   // BrowserPluginGuestManagerDelegate implementation.
   virtual int GetNextInstanceID() OVERRIDE;
   virtual void AddGuest(int guest_instance_id,
                         content::WebContents* guest_web_contents) OVERRIDE;
   virtual void RemoveGuest(int guest_instance_id) OVERRIDE;
-  virtual content::WebContents* GetGuestByInstanceID(
+  virtual void MaybeGetGuestByInstanceIDOrKill(
       int guest_instance_id,
-      int embedder_render_process_id) OVERRIDE;
-  virtual bool CanEmbedderAccessInstanceIDMaybeKill(
       int embedder_render_process_id,
-      int guest_instance_id) OVERRIDE;
-  virtual bool CanEmbedderAccessInstanceID(int embedder_render_process_id,
-                                           int guest_instance_id) OVERRIDE;
+      const GuestByInstanceIDCallback& callback) OVERRIDE;
   virtual content::SiteInstance* GetGuestSiteInstance(
       const GURL& guest_site) OVERRIDE;
   virtual bool ForEachGuest(content::WebContents* embedder_web_contents,
                             const GuestCallback& callback) OVERRIDE;
 
  private:
   friend class GuestWebContentsObserver;
 
   void AddRenderProcessHostID(int render_process_host_id);
 
+  content::WebContents* GetGuestByInstanceID(

[lazyboy, 2014/05/01 23:27:58]

Doc, also say when it returns NULL etc.

[Fady Samuel, 2014/05/06 16:51:36]

I documented the public method.

+      int guest_instance_id,
+      int embedder_render_process_id);
+
   static bool CanEmbedderAccessGuest(int embedder_render_process_id,
                                      GuestViewBase* guest);
 
   // Counts RenderProcessHost IDs of GuestViewBases.
   std::multiset<int> render_process_host_id_multiset_;
 
   // Contains guests' WebContents, mapping from their instance ids.
   typedef std::map<int, content::WebContents*> GuestInstanceMap;
   GuestInstanceMap guest_web_contents_by_instance_id_;
 
   int current_instance_id_;
   content::BrowserContext* context_;
 
   DISALLOW_COPY_AND_ASSIGN(GuestViewManager);
 };
 
 #endif  // CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_MANAGER_H_