Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 264933005: Add remote_install flag to extension sync data. (Closed)

Created:
6 years, 7 months ago by Marijn Kruisselbrink
Modified:
6 years, 7 months ago
Reviewers:
Yoyo Zhou, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, haitaol+watch_chromium.org, albertb+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Add remote_install flag to extension sync data. This is the first step in adding support for remote installation of extensions and apps. BUG=365737 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268053

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/extensions/app_sync_data_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 5 chunks +9 lines, -3 lines 0 comments Download
M sync/protocol/extension_specifics.proto View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Marijn Kruisselbrink
zea: can you review the sync changes? Split out from the larger CL in https://codereview.chromium.org/264763002/ ...
6 years, 7 months ago (2014-05-01 22:01:29 UTC) #1
Nicolas Zea
lgtm https://codereview.chromium.org/264933005/diff/1/sync/protocol/extension_specifics.proto File sync/protocol/extension_specifics.proto (right): https://codereview.chromium.org/264933005/diff/1/sync/protocol/extension_specifics.proto#newcode39 sync/protocol/extension_specifics.proto:39: // Whether this extension is being installed remotely. ...
6 years, 7 months ago (2014-05-02 20:46:05 UTC) #2
Marijn Kruisselbrink
https://codereview.chromium.org/264933005/diff/1/sync/protocol/extension_specifics.proto File sync/protocol/extension_specifics.proto (right): https://codereview.chromium.org/264933005/diff/1/sync/protocol/extension_specifics.proto#newcode39 sync/protocol/extension_specifics.proto:39: // Whether this extension is being installed remotely. On ...
6 years, 7 months ago (2014-05-02 21:28:53 UTC) #3
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 7 months ago (2014-05-02 22:32:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/264933005/20001
6 years, 7 months ago (2014-05-02 22:32:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 23:20:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 23:20:09 UTC) #7
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 7 months ago (2014-05-02 23:43:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/264933005/40001
6 years, 7 months ago (2014-05-02 23:44:22 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 06:14:19 UTC) #10
Message was sent while issue was closed. 
Change committed as 268053

Powered by Google App Engine
This is Rietveld 408576698