Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: third_party/WebKit/Source/modules/eventsource/EventSource.h

Issue 2649323005: Cleanly detach XHR and other pending loader clients from Inspector. (Closed)
Patch Set: rebalance XHR disposal steps Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/eventsource/EventSource.h
diff --git a/third_party/WebKit/Source/modules/eventsource/EventSource.h b/third_party/WebKit/Source/modules/eventsource/EventSource.h
index 33b22ee819f79ed7dd00348545ad0cad685eb981..0e0693310ba77acf65e661e790adafe6bf2fc604 100644
--- a/third_party/WebKit/Source/modules/eventsource/EventSource.h
+++ b/third_party/WebKit/Source/modules/eventsource/EventSource.h
@@ -59,6 +59,7 @@ class MODULES_EXPORT EventSource final
public EventSourceParser::Client {
DEFINE_WRAPPERTYPEINFO();
USING_GARBAGE_COLLECTED_MIXIN(EventSource);
+ USING_PRE_FINALIZER(EventSource, dispose);
public:
static EventSource* create(ExecutionContext*,
@@ -102,6 +103,8 @@ class MODULES_EXPORT EventSource final
private:
EventSource(ExecutionContext*, const KURL&, const EventSourceInit&);
+ void dispose();
+
void didReceiveResponse(unsigned long,
const ResourceResponse&,
std::unique_ptr<WebDataConsumerHandle>) override;

Powered by Google App Engine
This is Rietveld 408576698