Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2649323005: Cleanly detach XHR and other pending loader clients from Inspector. (Closed)
Patch Set: rebalance XHR disposal steps Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
index bb8ce8603553c733ba1e455ce9316211cfe24529..924771b166fd21112d6c47fd3b604f9f6f99cc1d 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
@@ -1025,6 +1025,20 @@ void InspectorNetworkAgent::didFinishEventSourceRequest(
clearPendingRequestData();
}
+void InspectorNetworkAgent::detachClientRequest(
+ ThreadableLoaderClient* client) {
+ // This method is called by loader clients when finalizing
+ // (i.e., from their "prefinalizers".) The client reference must
+ // no longer be held onto upon completion.
+ if (m_pendingRequest == client) {
+ m_pendingRequest = nullptr;
+ if (m_pendingRequestType == InspectorPageAgent::XHRResource) {
+ m_pendingXHRReplayData.clear();
+ }
+ }
+ m_knownRequestIdMap.remove(client);
+}
+
void InspectorNetworkAgent::applyUserAgentOverride(String* userAgent) {
String userAgentOverride;
m_state->getString(NetworkAgentState::userAgentOverride, &userAgentOverride);

Powered by Google App Engine
This is Rietveld 408576698