third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 2649323005: Cleanly detach XHR and other pending loader clients from Inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2649323005: Cleanly detach XHR and other pending loader clients from Inspector. (Closed)

Patch Set: detach all loader clients from inspector Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index 6da72cf763bc8e8dca39aee571e155ece6eed0cd..3375587e49c98f8f2b165ed6c6ad7f86a7963d47 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -676,6 +676,7 @@ void FetchManager::Loader::start() {

}

void FetchManager::Loader::dispose() {

+ InspectorInstrumentation::detachClientRequest(m_executionContext, this);

// Prevent notification

m_fetchManager = nullptr;

if (m_loader) {