Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2649323005: Cleanly detach XHR and other pending loader clients from Inspector. (Closed)
Patch Set: detach all loader clients from inspector Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1022 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 IdentifiersFactory::requestId(it->value), monotonicallyIncreasingTime(), 1033 IdentifiersFactory::requestId(it->value), monotonicallyIncreasingTime(),
1034 eventName.getString(), eventId.getString(), data); 1034 eventName.getString(), eventId.getString(), data);
1035 } 1035 }
1036 1036
1037 void InspectorNetworkAgent::didFinishEventSourceRequest( 1037 void InspectorNetworkAgent::didFinishEventSourceRequest(
1038 ThreadableLoaderClient* eventSource) { 1038 ThreadableLoaderClient* eventSource) {
1039 m_knownRequestIdMap.remove(eventSource); 1039 m_knownRequestIdMap.remove(eventSource);
1040 clearPendingRequestData(); 1040 clearPendingRequestData();
1041 } 1041 }
1042 1042
1043 void InspectorNetworkAgent::detachClientRequest(
yhirano 2017/01/25 11:06:26 ditto
1044 ThreadableLoaderClient* client) {
1045 if (m_pendingRequest == client) {
1046 m_pendingRequest = nullptr;
1047 if (m_pendingRequestType == InspectorPageAgent::XHRResource) {
1048 m_pendingXHRReplayData.clear();
1049 }
1050 }
1051 m_knownRequestIdMap.remove(client);
1052 }
1053
1043 void InspectorNetworkAgent::applyUserAgentOverride(String* userAgent) { 1054 void InspectorNetworkAgent::applyUserAgentOverride(String* userAgent) {
1044 String userAgentOverride; 1055 String userAgentOverride;
1045 m_state->getString(NetworkAgentState::userAgentOverride, &userAgentOverride); 1056 m_state->getString(NetworkAgentState::userAgentOverride, &userAgentOverride);
1046 if (!userAgentOverride.isEmpty()) 1057 if (!userAgentOverride.isEmpty())
1047 *userAgent = userAgentOverride; 1058 *userAgent = userAgentOverride;
1048 } 1059 }
1049 1060
1050 void InspectorNetworkAgent::willRecalculateStyle(Document*) { 1061 void InspectorNetworkAgent::willRecalculateStyle(Document*) {
1051 DCHECK(!m_isRecalculatingStyle); 1062 DCHECK(!m_isRecalculatingStyle);
1052 m_isRecalculatingStyle = true; 1063 m_isRecalculatingStyle = true;
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
1552 inspectedFrames->root()), 1563 inspectedFrames->root()),
1553 this, 1564 this,
1554 &InspectorNetworkAgent::removeFinishedReplayXHRFired) 1565 &InspectorNetworkAgent::removeFinishedReplayXHRFired)
1555 : nullptr) {} 1566 : nullptr) {}
1556 1567
1557 bool InspectorNetworkAgent::shouldForceCORSPreflight() { 1568 bool InspectorNetworkAgent::shouldForceCORSPreflight() {
1558 return m_state->booleanProperty(NetworkAgentState::cacheDisabled, false); 1569 return m_state->booleanProperty(NetworkAgentState::cacheDisabled, false);
1559 } 1570 }
1560 1571
1561 } // namespace blink 1572 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698