components/metrics/proto/ukm/source.proto - Issue 2649303004: UKM: Added support for navigation sources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/proto/ukm/source.proto

Issue 2649303004: UKM: Added support for navigation sources (Closed)

Patch Set: Removed redundant test steps Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/proto/ukm/source.proto

diff --git a/components/metrics/proto/ukm/source.proto b/components/metrics/proto/ukm/source.proto

index 44afe3a737b1905068e331a3a2f2c97045e8f323..e48f252cc9380fb6080affe4baa73ae9f9fc5470 100644

--- a/components/metrics/proto/ukm/source.proto

+++ b/components/metrics/proto/ukm/source.proto

@@ -24,6 +24,6 @@ message Source {

// events related to this Source will generally be relative to this timestamp.

optional int64 navigation_time_msec = 3;

- // Time between navigation and the first meaningful paint, in milliseconds.

- optional int64 first_meaningful_paint_msec = 4;

+ // Time between navigation and the first contentful paint, in milliseconds.

+ optional int64 first_contentful_paint_msec = 4;

Alexei Svitkine (slow) 2017/01/25 15:35:04 Please land this change server-side first before l

oystein (OOO til 10th of July) 2017/01/25 18:38:04 Acknowledged.

}

« no previous file with comments | « no previous file | components/ukm/BUILD.gn » ('j') | components/ukm/test_ukm_service.h » ('J')