Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2649283003: Reland "VM: Fix memory leaks during isolate spawning" (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland "VM: Fix memory leaks during isolate spawning" R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/89de0c9267843a0ca99ab058aea76634bb3fa1cc

Patch Set 1 #

Patch Set 2 : Fix bug #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -35 lines) Patch
M runtime/lib/isolate.cc View 1 3 chunks +40 lines, -12 lines 0 comments Download
M runtime/vm/datastream.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.h View 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/isolate.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M runtime/vm/snapshot.h View 2 chunks +33 lines, -2 lines 2 comments Download
M runtime/vm/snapshot.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
3 years, 11 months ago (2017-01-24 10:08:10 UTC) #2
Vyacheslav Egorov (Google)
LGTM https://codereview.chromium.org/2649283003/diff/20001/runtime/vm/snapshot.h File runtime/vm/snapshot.h (right): https://codereview.chromium.org/2649283003/diff/20001/runtime/vm/snapshot.h#newcode1011 runtime/vm/snapshot.h:1011: MessageWriter(uint8_t** buffer, Another good refactoring would actually be ...
3 years, 11 months ago (2017-01-24 10:45:41 UTC) #3
kustermann
https://codereview.chromium.org/2649283003/diff/20001/runtime/vm/snapshot.h File runtime/vm/snapshot.h (right): https://codereview.chromium.org/2649283003/diff/20001/runtime/vm/snapshot.h#newcode1011 runtime/vm/snapshot.h:1011: MessageWriter(uint8_t** buffer, On 2017/01/24 10:45:41, Vyacheslav Egorov (Google) wrote: ...
3 years, 11 months ago (2017-01-24 11:03:50 UTC) #4
kustermann
3 years, 11 months ago (2017-01-24 11:04:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
89de0c9267843a0ca99ab058aea76634bb3fa1cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698