Add a whitelist check for nacl-nonsfi mode

extensions/common/manifest_handlers/shared_module_info.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/manifest_handlers/shared_module_info.h"
 
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 68 matching lines @@
 // static
 bool SharedModuleInfo::IsExportAllowed(const Extension* extension,
                                        const std::string& relative_path) {
   return GetSharedModuleInfo(extension).
       exported_set_.MatchesURL(extension->url().Resolve(relative_path));
 }
 
 // static
 bool SharedModuleInfo::IsExportAllowedByWhitelist(const Extension* extension,
                                                   const std::string& other_id) {
+  // Sanity check. In case the caller did not check |extension| to make sure it
+  // is a shared module, we do not want it to appear that the extension with
+  // |other_id| importing |extension| is valid.
+  if (!SharedModuleInfo::IsSharedModule(extension))
+    return false;
   const SharedModuleInfo& info = GetSharedModuleInfo(extension);
   if (info.export_whitelist_.empty())
     return true;
   if (info.export_whitelist_.find(other_id) != info.export_whitelist_.end())
     return true;
   return false;
 }
 
 // static
 bool SharedModuleInfo::ImportsExtensionById(const Extension* extension,
@@ skipping 148 matching lines @@
 
 const std::vector<std::string> SharedModuleHandler::Keys() const {
   static const char* keys[] = {
     keys::kExport,
     keys::kImport
   };
   return std::vector<std::string>(keys, keys + arraysize(keys));
 }
 
 }  // namespace extensions