Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 264923007: Add java_cpp_template template (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add java_cpp_template template This is the GN version of build/java_cpp_template.gypi. It defines a template that wraps an action_foreach that generates .java files using the host C preprocessor. The major difference in the GN version is that it takes all the generated java files and zips them together in a single .srcjar. When such a target is included in the srcjar_deps of a java library, the .java files in the .srcjar will be treated much like files listed in that libraries java_sources (particularly they will be compiled and included in the .jar/.dex). Depends on https://crrev.com/264773014/ BUG=359249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272775

Patch Set 1 : #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Rebase #

Patch Set 4 : Another Rebase #

Patch Set 5 : Make zip template public (since it is in a different file) :/ #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -0 lines) Patch
M base/BUILD.gn View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A build/android/gn/zip.py View 1 chunk +39 lines, -0 lines 0 comments Download
A build/config/android/internal_rules.gni View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 2 3 4 2 chunks +82 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cjhopman
brettw: *
6 years, 7 months ago (2014-05-05 20:48:59 UTC) #1
brettw
lgtm https://codereview.chromium.org/264923007/diff/40001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/264923007/diff/40001/base/BUILD.gn#newcode941 base/BUILD.gn:941: ] out-dent ] by 2 spaces (same below) ...
6 years, 7 months ago (2014-05-06 18:06:35 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 7 months ago (2014-05-22 00:06:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/264923007/100001
6 years, 7 months ago (2014-05-22 00:07:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 06:34:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 09:32:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9702)
6 years, 7 months ago (2014-05-22 09:32:36 UTC) #7
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 7 months ago (2014-05-25 23:18:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/264923007/120001
6 years, 7 months ago (2014-05-25 23:18:14 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 04:01:52 UTC) #10
Message was sent while issue was closed.
Change committed as 272775

Powered by Google App Engine
This is Rietveld 408576698