components/payments/payment_request.cc - Issue 2649143003: PaymentRequest: The currencySystem should be non-nullable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/payments/payment_request.cc

Issue 2649143003: PaymentRequest: The currencySystem should be non-nullable. (Closed)

Patch Set: PaymentRequest: The currencySystem should be non-nullable. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/payments/payment_request.cc

diff --git a/components/payments/payment_request.cc b/components/payments/payment_request.cc

index 282b3fa38afad3d8ef83f6db57f9f05c532ca0ad..1d829b06908c6e15a0edf07f7a93be6458b9b6fb 100644

--- a/components/payments/payment_request.cc

+++ b/components/payments/payment_request.cc

@@ -65,7 +65,7 @@ void PaymentRequest::OnError() {

CurrencyFormatter* PaymentRequest::GetOrCreateCurrencyFormatter(

const std::string& currency_code,

- const base::Optional<std::string> currency_system,

+ const std::string& currency_system,

const std::string& locale_name) {

if (!currency_formatter_) {

currency_formatter_.reset(

« no previous file with comments | « components/payments/payment_request.h ('k') | components/payments/payment_request.mojom » ('j') | no next file with comments »