components/payments/android/currency_formatter_android.cc - Issue 2649143003: PaymentRequest: The currencySystem should be non-nullable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/payments/android/currency_formatter_android.cc

Issue 2649143003: PaymentRequest: The currencySystem should be non-nullable. (Closed)

Patch Set: PaymentRequest: The currencySystem should be non-nullable. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/payments/android/currency_formatter_android.cc

diff --git a/components/payments/android/currency_formatter_android.cc b/components/payments/android/currency_formatter_android.cc

index 00143f3214e59766fa6e2880b76ff4387f11111e..e1ea023e21036e4575386068497b790a0e7b57b2 100644

--- a/components/payments/android/currency_formatter_android.cc

+++ b/components/payments/android/currency_formatter_android.cc

@@ -25,10 +25,7 @@ CurrencyFormatterAndroid::CurrencyFormatterAndroid(

ConvertJavaStringToUTF8(env, currency_system);

currency_formatter_.reset(new CurrencyFormatter(

- ConvertJavaStringToUTF8(env, currency_code),

- currency_system_str.empty()

- ? base::Optional<std::string>()

- : base::Optional<std::string>(currency_system_str),

+ ConvertJavaStringToUTF8(env, currency_code), currency_system_str,

ConvertJavaStringToUTF8(env, locale_name)));

}