Issue 264913006: self._Capture -> scm.GIT.Capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264913006: self._Capture -> scm.GIT.Capture. (Closed)

Created:
6 years, 7 months ago by szager1

Modified:
6 years, 7 months ago

Reviewers:
agable, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

self._Capture -> scm.GIT.Capture. This is a special case where we want to run a git command, even if it's an SVNWrapper instance. R=iannucci@chromium.org,agable@chromium.org BUG=369145 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=267707

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	gclient_scm.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

agable

LGTM this is definitely the simplest fix, even though it leaves the messy inheritance behind.

6 years, 7 months ago (2014-05-02 00:47:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/264913006/1

6 years, 7 months ago (2014-05-02 00:55:26 UTC) #5

Message was sent while issue was closed.

Change committed as 267707