Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 264913003: Changes shift key icon & highlight/caps UX. (Closed)

Created:
6 years, 7 months ago by rsadam
Modified:
6 years, 7 months ago
Reviewers:
kevers
CC:
chromium-reviews
Visibility:
Public.

Description

Changes shift key icon & highlight/caps UX. BUG=364468 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267771

Patch Set 1 #

Patch Set 2 : Remove unused icons. #

Total comments: 2

Patch Set 3 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -82 lines) Patch
M ui/keyboard/keyboard_resources.grd View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/keyboard/resources/elements/kb-key.html View 3 chunks +7 lines, -3 lines 0 comments Download
M ui/keyboard/resources/elements/kb-shift-key.html View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/resources/images/down.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/left.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/images/right.svg View 1 chunk +1 line, -1 line 0 comments Download
A ui/keyboard/resources/images/search.png View Binary file 0 comments Download
D ui/keyboard/resources/images/search.svg View 1 1 chunk +0 lines, -19 lines 0 comments Download
A ui/keyboard/resources/images/shift.png View Binary file 0 comments Download
D ui/keyboard/resources/images/shift.svg View 1 1 chunk +0 lines, -17 lines 0 comments Download
D ui/keyboard/resources/images/shift-filled.svg View 1 1 chunk +0 lines, -16 lines 0 comments Download
M ui/keyboard/resources/images/tab.png View Binary file 0 comments Download
M ui/keyboard/resources/images/up.svg View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/layouts/system-qwerty.html View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/keyboard/resources/main.css View 1 2 1 chunk +5 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
rsadam
PTAL!
6 years, 7 months ago (2014-05-01 17:49:19 UTC) #1
kevers
lgtm with nit. https://codereview.chromium.org/264913003/diff/20001/ui/keyboard/resources/main.css File ui/keyboard/resources/main.css (right): https://codereview.chromium.org/264913003/diff/20001/ui/keyboard/resources/main.css#newcode20 ui/keyboard/resources/main.css:20: -webkit-box-shadow: inset 0 0 3px 2px ...
6 years, 7 months ago (2014-05-01 18:12:58 UTC) #2
rsadam
https://codereview.chromium.org/264913003/diff/20001/ui/keyboard/resources/main.css File ui/keyboard/resources/main.css (right): https://codereview.chromium.org/264913003/diff/20001/ui/keyboard/resources/main.css#newcode20 ui/keyboard/resources/main.css:20: -webkit-box-shadow: inset 0 0 3px 2px #aaaaaa; On 2014/05/01 ...
6 years, 7 months ago (2014-05-01 18:45:45 UTC) #3
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-05-01 18:45:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/264913003/40001
6 years, 7 months ago (2014-05-01 18:47:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 18:51:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 18:51:10 UTC) #7
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-05-01 19:49:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/264913003/40001
6 years, 7 months ago (2014-05-01 19:50:46 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 20:44:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 20:44:45 UTC) #11
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-05-01 21:27:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/264913003/40001
6 years, 7 months ago (2014-05-01 21:27:55 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 03:39:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 03:39:16 UTC) #15
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-05-02 03:42:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/264913003/40001
6 years, 7 months ago (2014-05-02 03:43:11 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 09:38:22 UTC) #18
Message was sent while issue was closed. 
Change committed as 267771

Powered by Google App Engine
This is Rietveld 408576698