Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectModel.h

Issue 2649103007: Make PropertyHandle instances const references where possible (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/KeyframeEffectModel.h
diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h
index ac349191f420f3cc454c6476d4d627088ecacf44..a92b608f5cb84883cef9c15674bf926f6b87102a 100644
--- a/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h
+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h
@@ -83,7 +83,7 @@ class CORE_EXPORT KeyframeEffectModelBase : public EffectModel {
void setFrames(KeyframeVector& keyframes);
const PropertySpecificKeyframeVector& getPropertySpecificKeyframes(
- PropertyHandle property) const {
+ const PropertyHandle& property) const {
ensureKeyframeGroups();
return m_keyframeGroups->get(property)->keyframes();
}
@@ -128,7 +128,7 @@ class CORE_EXPORT KeyframeEffectModelBase : public EffectModel {
return normalizedKeyframes(keyframes);
}
- bool affects(PropertyHandle property) const override {
+ bool affects(const PropertyHandle& property) const override {
ensureKeyframeGroups();
return m_keyframeGroups->contains(property);
}

Powered by Google App Engine
This is Rietveld 408576698