Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h

Issue 2649103007: Make PropertyHandle instances const references where possible (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
diff --git a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
index 2fb90cc365528b307a1386e99b77a06bba41ffa4..c017104d4441c47d3fb44b607346ffb43dff51e9 100644
--- a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
+++ b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
@@ -20,14 +20,14 @@ namespace blink {
class CORE_EXPORT InvalidatableInterpolation : public Interpolation {
public:
static PassRefPtr<InvalidatableInterpolation> create(
- PropertyHandle property,
+ const PropertyHandle& property,
PassRefPtr<PropertySpecificKeyframe> startKeyframe,
PassRefPtr<PropertySpecificKeyframe> endKeyframe) {
return adoptRef(new InvalidatableInterpolation(
property, std::move(startKeyframe), std::move(endKeyframe)));
}
- PropertyHandle getProperty() const final { return m_property; }
+ const PropertyHandle& getProperty() const final { return m_property; }
virtual void interpolate(int iteration, double fraction);
bool dependsOnUnderlyingValue() const final;
static void applyStack(const ActiveInterpolations&,
@@ -36,7 +36,7 @@ class CORE_EXPORT InvalidatableInterpolation : public Interpolation {
virtual bool isInvalidatableInterpolation() const { return true; }
private:
- InvalidatableInterpolation(PropertyHandle property,
+ InvalidatableInterpolation(const PropertyHandle& property,
PassRefPtr<PropertySpecificKeyframe> startKeyframe,
PassRefPtr<PropertySpecificKeyframe> endKeyframe)
: Interpolation(),
« no previous file with comments | « third_party/WebKit/Source/core/animation/InterpolationEffect.cpp ('k') | third_party/WebKit/Source/core/animation/Keyframe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698