Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Side by Side Diff: third_party/WebKit/Source/core/animation/StringKeyframe.h

Issue 2649103007: Make PropertyHandle instances const references where possible (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef StringKeyframe_h 5 #ifndef StringKeyframe_h
6 #define StringKeyframe_h 6 #define StringKeyframe_h
7 7
8 #include "core/animation/Keyframe.h" 8 #include "core/animation/Keyframe.h"
9 #include "core/css/StylePropertySet.h" 9 #include "core/css/StylePropertySet.h"
10 10
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 private: 150 private:
151 StringKeyframe() 151 StringKeyframe()
152 : m_cssPropertyMap(MutableStylePropertySet::create(HTMLStandardMode)), 152 : m_cssPropertyMap(MutableStylePropertySet::create(HTMLStandardMode)),
153 m_presentationAttributeMap( 153 m_presentationAttributeMap(
154 MutableStylePropertySet::create(HTMLStandardMode)) {} 154 MutableStylePropertySet::create(HTMLStandardMode)) {}
155 155
156 StringKeyframe(const StringKeyframe& copyFrom); 156 StringKeyframe(const StringKeyframe& copyFrom);
157 157
158 PassRefPtr<Keyframe> clone() const override; 158 PassRefPtr<Keyframe> clone() const override;
159 PassRefPtr<Keyframe::PropertySpecificKeyframe> createPropertySpecificKeyframe( 159 PassRefPtr<Keyframe::PropertySpecificKeyframe> createPropertySpecificKeyframe(
160 PropertyHandle) const override; 160 const PropertyHandle&) const override;
161 161
162 bool isStringKeyframe() const override { return true; } 162 bool isStringKeyframe() const override { return true; }
163 163
164 Persistent<MutableStylePropertySet> m_cssPropertyMap; 164 Persistent<MutableStylePropertySet> m_cssPropertyMap;
165 Persistent<MutableStylePropertySet> m_presentationAttributeMap; 165 Persistent<MutableStylePropertySet> m_presentationAttributeMap;
166 HashMap<const QualifiedName*, String> m_svgAttributeMap; 166 HashMap<const QualifiedName*, String> m_svgAttributeMap;
167 }; 167 };
168 168
169 using CSSPropertySpecificKeyframe = StringKeyframe::CSSPropertySpecificKeyframe; 169 using CSSPropertySpecificKeyframe = StringKeyframe::CSSPropertySpecificKeyframe;
170 using SVGPropertySpecificKeyframe = StringKeyframe::SVGPropertySpecificKeyframe; 170 using SVGPropertySpecificKeyframe = StringKeyframe::SVGPropertySpecificKeyframe;
(...skipping 10 matching lines...) Expand all
181 value.isCSSPropertySpecificKeyframe()); 181 value.isCSSPropertySpecificKeyframe());
182 DEFINE_TYPE_CASTS(SVGPropertySpecificKeyframe, 182 DEFINE_TYPE_CASTS(SVGPropertySpecificKeyframe,
183 Keyframe::PropertySpecificKeyframe, 183 Keyframe::PropertySpecificKeyframe,
184 value, 184 value,
185 value->isSVGPropertySpecificKeyframe(), 185 value->isSVGPropertySpecificKeyframe(),
186 value.isSVGPropertySpecificKeyframe()); 186 value.isSVGPropertySpecificKeyframe());
187 187
188 } // namespace blink 188 } // namespace blink
189 189
190 #endif 190 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698