third_party/WebKit/Source/core/animation/Interpolation.h - Issue 2649103007: Make PropertyHandle instances const references where possible

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/animation/Interpolation.h

Issue 2649103007: Make PropertyHandle instances const references where possible (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef Interpolation_h	5 #ifndef Interpolation_h

6 #define Interpolation_h	6 #define Interpolation_h

7	7

8 #include "core/CoreExport.h"	8 #include "core/CoreExport.h"

9 #include "core/animation/InterpolableValue.h"	9 #include "core/animation/InterpolableValue.h"

10 #include "wtf/Forward.h"	10 #include "wtf/Forward.h"

(...skipping 10 matching lines...) Expand all Loading...
21 WTF_MAKE_NONCOPYABLE(Interpolation);	21 WTF_MAKE_NONCOPYABLE(Interpolation);

22	22

23 public:	23 public:

24 virtual ~Interpolation() {}	24 virtual ~Interpolation() {}

25	25

26 virtual void interpolate(int iteration, double fraction) = 0;	26 virtual void interpolate(int iteration, double fraction) = 0;

27	27

28 virtual bool isInvalidatableInterpolation() const { return false; }	28 virtual bool isInvalidatableInterpolation() const { return false; }

29 virtual bool isLegacyStyleInterpolation() const { return false; }	29 virtual bool isLegacyStyleInterpolation() const { return false; }

30	30

31 virtual PropertyHandle getProperty() const = 0;	31 virtual const PropertyHandle& getProperty() const = 0;

32 virtual bool dependsOnUnderlyingValue() const { return false; }	32 virtual bool dependsOnUnderlyingValue() const { return false; }

33	33

34 protected:	34 protected:

35 Interpolation() {}	35 Interpolation() {}

36 };	36 };

37	37

38 using ActiveInterpolations = Vector<RefPtr<Interpolation>, 1>;	38 using ActiveInterpolations = Vector<RefPtr<Interpolation>, 1>;

39	39

40 } // namespace blink	40 } // namespace blink

41	41

42 #endif // Interpolation_h	42 #endif // Interpolation_h

OLD	NEW