Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: ios/net/cookies/cookie_store_ios_unittest.mm

Issue 2649083002: Divide CookieStoreIOS into two different classes with different backends (Closed)
Patch Set: Eugene's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/net/cookies/cookie_store_ios_unittest.mm
diff --git a/ios/net/cookies/cookie_store_ios_unittest.mm b/ios/net/cookies/cookie_store_ios_unittest.mm
index 25338d4258361b98a80824e6ea30014e5f5e7d99..d87b11b6ba729bbe7da5d28add99767ae040f24a 100644
--- a/ios/net/cookies/cookie_store_ios_unittest.mm
+++ b/ios/net/cookies/cookie_store_ios_unittest.mm
@@ -14,6 +14,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/sys_string_conversions.h"
+#import "ios/net/cookies/cookie_store_ios_persistent.h"
#import "net/base/mac/url_conversions.h"
#include "net/cookies/cookie_store_unittest.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -35,9 +36,8 @@ namespace net {
struct CookieStoreIOSTestTraits {
static std::unique_ptr<net::CookieStore> Create() {
ClearCookies();
- std::unique_ptr<CookieStoreIOS> store(new CookieStoreIOS(nullptr));
- store->synchronization_state_ = CookieStoreIOS::SYNCHRONIZED;
- return std::move(store);
+ return base::MakeUnique<CookieStoreIOS>(
+ [NSHTTPCookieStorage sharedHTTPCookieStorage]);
}
static const bool supports_http_only = false;
@@ -53,7 +53,7 @@ struct CookieStoreIOSTestTraits {
struct InactiveCookieStoreIOSTestTraits {
static std::unique_ptr<net::CookieStore> Create() {
- return base::MakeUnique<CookieStoreIOS>(nullptr);
+ return base::MakeUnique<CookieStoreIOSPersistent>(nullptr);
}
static const bool is_cookie_monster = false;
@@ -231,7 +231,8 @@ class NotSynchronizedCookieStoreIOSWithBackend : public testing::Test {
NotSynchronizedCookieStoreIOSWithBackend()
: kTestCookieURL("http://foo.google.com/bar"),
backend_(new TestPersistentCookieStore),
- store_(new net::CookieStoreIOS(backend_.get())) {
+ store_(
+ base::MakeUnique<net::CookieStoreIOSPersistent>(backend_.get())) {
cookie_changed_callback_ = store_->AddCallbackForCookie(
kTestCookieURL, "abc",
base::Bind(&RecordCookieChanges, &cookies_changed_, &cookies_removed_));
@@ -274,7 +275,7 @@ class SynchronizedCookieStoreIOS : public testing::Test {
kTestCookieURL3("http://foo.google.com"),
kTestCookieURL4("http://bar.google.com/bar"),
backend_(new TestPersistentCookieStore),
- store_(net::CookieStoreIOS::CreateCookieStore(
+ store_(base::MakeUnique<net::CookieStoreIOS>(
[NSHTTPCookieStorage sharedHTTPCookieStorage])) {
cookie_changed_callback_ = store_->AddCallbackForCookie(
kTestCookieURL, "abc",
@@ -418,9 +419,9 @@ TEST(CookieStoreIOS, GetAllCookiesForURLAsync) {
base::MessageLoop loop;
const GURL kTestCookieURL("http://foo.google.com/bar");
ClearCookies();
- std::unique_ptr<CookieStoreIOS> cookie_store(
- CookieStoreIOS::CreateCookieStore(
- [NSHTTPCookieStorage sharedHTTPCookieStorage]));
+ std::unique_ptr<CookieStoreIOS> cookie_store(base::MakeUnique<CookieStoreIOS>(
+ [NSHTTPCookieStorage sharedHTTPCookieStorage]));
+
// Add a cookie.
net::CookieOptions options;
options.set_include_httponly();

Powered by Google App Engine
This is Rietveld 408576698