third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp - Issue 2649073002: Use a new Supplement constructor in Navigator supplements (part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

Issue 2649073002: Use a new Supplement constructor in Navigator supplements (part 2) (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

diff --git a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

index 77c0ce17a2369290356d15bd872b5cb3c38f69a3..8b2139a623e3304ca05be6f28a136173dd5a45ab 100644

--- a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

+++ b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

@@ -34,7 +34,8 @@

namespace blink {

NavigatorVibration::NavigatorVibration(Navigator& navigator)

- : ContextLifecycleObserver(navigator.frame()->document()) {}

+ : Supplement<Navigator>(navigator),

+ ContextLifecycleObserver(navigator.frame()->document()) {}

sof 2017/01/23 08:19:17 Need a frame() null check here as well?

NavigatorVibration::~NavigatorVibration() {}